New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libgetopts: tweak HasHarg/Occur docs #16252
Conversation
| Optional, | ||
| /// The option occurs once or multiple times. | ||
| /// The option occurs zero or more times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be one or more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it shouldn't. That's partly why I'm making this PR. With Occur set to Multi, it is allowed for the option not to show up at all. With this PR, I'm assuming that the code is correct but the docs a little outdated.
|
Ok, thanks! Could you squash the commits together as well? |
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at https://github.com/conradkleinespel/rust/commit/c74d320662329922860c5cdaf8cba1797caebea4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging conradkleinespel/rust/master = c74d320 into auto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/701
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/701
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/700
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/701
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/697
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/698
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/697
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/703
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/698
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/697
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/700
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/698
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/698
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/699
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 2a47fa7
I found the current docs to be a little confusing. I believe this makes them straight to the point and less confusing.
I found the current docs to be a little confusing. I believe this makes them straight to the point and less confusing.